RE: [PATCH net-netx] net: lan78xx: add LAN7801 MAC-only support

2016-11-29 Thread Woojung.Huh
> > It seems phy_unregister_fixup() will be needed for module network driver. > > phy_fixup_list keeps the list even after unloading module. > > Do you know any update is waiting for submission? If not, I'll make patch. > > Oh, yes, that's a good point, we need such a thing, so far fixups have > b

Re: [PATCH net-netx] net: lan78xx: add LAN7801 MAC-only support

2016-11-29 Thread Florian Fainelli
On 11/29/2016 03:55 PM, woojung@microchip.com wrote: >> There are two ways to get these settings propagated to the PHY driver: >> >> - using a board fixup which is going to be invoked during >> drv->config_init() time >> >> - specifying a phydev->dev_flags and reading it from the PHY driver to

RE: [PATCH net-netx] net: lan78xx: add LAN7801 MAC-only support

2016-11-29 Thread Woojung.Huh
> There are two ways to get these settings propagated to the PHY driver: > > - using a board fixup which is going to be invoked during > drv->config_init() time > > - specifying a phydev->dev_flags and reading it from the PHY driver to > act upon and configure the PHY based on that value, there a

RE: [PATCH net-netx] net: lan78xx: add LAN7801 MAC-only support

2016-11-29 Thread Woojung.Huh
> There are two ways to get these settings propagated to the PHY driver: > > - using a board fixup which is going to be invoked during > drv->config_init() time > > - specifying a phydev->dev_flags and reading it from the PHY driver to > act upon and configure the PHY based on that value, there a

Re: [PATCH net-netx] net: lan78xx: add LAN7801 MAC-only support

2016-11-29 Thread Florian Fainelli
On 11/29/2016 10:49 AM, woojung@microchip.com wrote: >>> + /* LED2/PME_N/IRQ_N/RGMII_ID pin to IRQ_N mode */ >>> + buf = phy_read_mmd_indirect(phydev, 32784, 3); >>> + buf &= ~0x1800; >>> + buf |= 0x0800; >>> + phy_write_mmd_indirect(phydev, 32784, 3, buf); >> >> Using decimal numbers

RE: [PATCH net-netx] net: lan78xx: add LAN7801 MAC-only support

2016-11-29 Thread Woojung.Huh
> > + /* LED2/PME_N/IRQ_N/RGMII_ID pin to IRQ_N mode */ > > + buf = phy_read_mmd_indirect(phydev, 32784, 3); > > + buf &= ~0x1800; > > + buf |= 0x0800; > > + phy_write_mmd_indirect(phydev, 32784, 3, buf); > > Using decimal numbers for register addresses is a bit unusual. OK. Will change

Re: [PATCH net-netx] net: lan78xx: add LAN7801 MAC-only support

2016-11-29 Thread Florian Fainelli
On 11/28/2016 12:03 PM, woojung@microchip.com wrote: > From: Woojung Huh > > Add LAN7801 MAC-only configuration support. > > Signed-off-by: Woojung Huh > --- > drivers/net/usb/Kconfig | 5 +++ > drivers/net/usb/lan78xx.c | 111 > +- > driver

[PATCH net-netx] net: lan78xx: add LAN7801 MAC-only support

2016-11-28 Thread Woojung.Huh
From: Woojung Huh Add LAN7801 MAC-only configuration support. Signed-off-by: Woojung Huh --- drivers/net/usb/Kconfig | 5 +++ drivers/net/usb/lan78xx.c | 111 +- drivers/net/usb/lan78xx.h | 14 ++ 3 files changed, 128 insertions(+), 2 deleti