On 11/29/2016 03:55 PM, woojung....@microchip.com wrote: >> There are two ways to get these settings propagated to the PHY driver: >> >> - using a board fixup which is going to be invoked during >> drv->config_init() time >> >> - specifying a phydev->dev_flags and reading it from the PHY driver to >> act upon and configure the PHY based on that value, there are only >> 32-bits available though, and you need to make sure they are not >> conflicting with other potential users in tree >> >> My preference would go with 1, since you could just register it in your >> PHY driver and re-use the code you are proposing to include here. > > Florian, > > It seems phy_unregister_fixup() will be needed for module network driver. > phy_fixup_list keeps the list even after unloading module. > Do you know any update is waiting for submission? If not, I'll make patch.
Oh, yes, that's a good point, we need such a thing, so far fixups have been exclusively used by code that is built-in, but there really is not a reason for that. Please go ahead and cook a patch for this, thanks! -- Florian
