Re: [PATCH net] vxlan: do not use fdb in metadata mode

2016-02-18 Thread David Miller
From: Jiri Benc Date: Tue, 16 Feb 2016 22:18:26 +0100 > In metadata mode, the vxlan interface is not supposed to use the fdb control > plane but an external one (openvswitch or static routes). With the current > code, packets may leak into the fdb handling code which usually causes them > to be d

Re: [PATCH net] vxlan: do not use fdb in metadata mode

2016-02-18 Thread Jiri Benc
On Thu, 18 Feb 2016 15:32:40 +0900, Simon Horman wrote: > The logic here looks correct to me but I am curious to know > what circumstances would lead to the kfree_skb() case. Setting up the interface in "external" (VXLAN_F_COLLECT_METADATA) mode, assigning an IP address and not setting a route wit

Re: [PATCH net] vxlan: do not use fdb in metadata mode

2016-02-17 Thread Simon Horman
Hi Jiri, On Tue, Feb 16, 2016 at 10:18:26PM +0100, Jiri Benc wrote: > In metadata mode, the vxlan interface is not supposed to use the fdb control > plane but an external one (openvswitch or static routes). With the current > code, packets may leak into the fdb handling code which usually causes t

[PATCH net] vxlan: do not use fdb in metadata mode

2016-02-16 Thread Jiri Benc
In metadata mode, the vxlan interface is not supposed to use the fdb control plane but an external one (openvswitch or static routes). With the current code, packets may leak into the fdb handling code which usually causes them to be dropped anyway but may have strange side effects. Just drop the