Hi Jiri,
On Tue, Feb 16, 2016 at 10:18:26PM +0100, Jiri Benc wrote:
> In metadata mode, the vxlan interface is not supposed to use the fdb control
> plane but an external one (openvswitch or static routes). With the current
> code, packets may leak into the fdb handling code which usually causes them
> to be dropped anyway but may have strange side effects.
>
> Just drop the packets directly when in metadata mode if the destination data
> are not correctly provided on egress.
>
> Signed-off-by: Jiri Benc <jb...@redhat.com>
The logic here looks correct to me but I am curious to know
what circumstances would lead to the kfree_skb() case.
> ---
> drivers/net/vxlan.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index db96f3a16f6c..e6944b29588e 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -2171,9 +2171,11 @@ static netdev_tx_t vxlan_xmit(struct sk_buff *skb,
> struct net_device *dev)
> #endif
> }
>
> - if (vxlan->flags & VXLAN_F_COLLECT_METADATA &&
> - info && info->mode & IP_TUNNEL_INFO_TX) {
> - vxlan_xmit_one(skb, dev, NULL, false);
> + if (vxlan->flags & VXLAN_F_COLLECT_METADATA) {
> + if (info && info->mode & IP_TUNNEL_INFO_TX)
> + vxlan_xmit_one(skb, dev, NULL, false);
> + else
> + kfree_skb(skb);
> return NETDEV_TX_OK;
> }
>
> --
> 1.8.3.1
>
