Re: [PATCH net] rocker: move dereference before free

2017-06-29 Thread David Miller
From: Dan Carpenter Date: Wed, 28 Jun 2017 14:44:21 +0300 > My static checker complains that ofdpa_neigh_del() can sometimes free > "found". It just makes sense to use it first before deleting it. > > Fixes: ecf244f753e0 ("rocker: fix maybe-uninitialized warning") > Signed-off-by: Dan Carpente

[PATCH net] rocker: move dereference before free

2017-06-28 Thread Dan Carpenter
My static checker complains that ofdpa_neigh_del() can sometimes free "found". It just makes sense to use it first before deleting it. Fixes: ecf244f753e0 ("rocker: fix maybe-uninitialized warning") Signed-off-by: Dan Carpenter --- Most ref counting function use atomic_dec() but ofdpa_neigh_del