From: Dan Carpenter <[email protected]>
Date: Wed, 28 Jun 2017 14:44:21 +0300

> My static checker complains that ofdpa_neigh_del() can sometimes free
> "found".   It just makes sense to use it first before deleting it.
> 
> Fixes: ecf244f753e0 ("rocker: fix maybe-uninitialized warning")
> Signed-off-by: Dan Carpenter <[email protected]>

Applied, thanks.

> Most ref counting function use atomic_dec() but ofdpa_neigh_del() just
> uses normal decrement.  Are you sure this isn't racy?

A spinlock is held always when this counter is touched.

Reply via email to