Re: [PATCH net] r8169: fix potential skb double free in an error path

2020-11-07 Thread Jakub Kicinski
On Thu, 5 Nov 2020 15:28:42 +0100 Heiner Kallweit wrote: > The caller of rtl8169_tso_csum_v2() frees the skb if false is returned. > eth_skb_pad() internally frees the skb on error what would result in a > double free. Therefore use __skb_put_padto() directly and instruct it > to not free the skb o

[PATCH net] r8169: fix potential skb double free in an error path

2020-11-05 Thread Heiner Kallweit
The caller of rtl8169_tso_csum_v2() frees the skb if false is returned. eth_skb_pad() internally frees the skb on error what would result in a double free. Therefore use __skb_put_padto() directly and instruct it to not free the skb on error. Fixes: 25e992a4603c ("r8169: rename r8169.c to r8169_m