On Thu, 5 Nov 2020 15:28:42 +0100 Heiner Kallweit wrote: > The caller of rtl8169_tso_csum_v2() frees the skb if false is returned. > eth_skb_pad() internally frees the skb on error what would result in a > double free. Therefore use __skb_put_padto() directly and instruct it > to not free the skb on error. > > Fixes: 25e992a4603c ("r8169: rename r8169.c to r8169_main.c") > Reported-by: Jakub Kicinski <k...@kernel.org> > Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> > --- > The Fixes tag refers to the change from which on the patch applies. > However it will apply with a little fuzz only on versions up to 5.9.
I think we've been over this, please provide real fixes tags, pointing to where bugs were introduced. I swapped the tag for: Fixes: b423e9ae49d7 ("r8169: fix offloaded tx checksum for small packets.") and applied, thanks.