Re: [PATCH net] net: sched: fix unbalance in the error path of tca_action_flush()

2018-02-16 Thread David Miller
From: Davide Caratti Date: Thu, 15 Feb 2018 15:50:57 +0100 > When tca_action_flush() calls the action walk() and gets an error, > a successful call to nla_nest_start() is not followed by a call to > nla_nest_cancel(). It's harmless, as the skb is freed in the error > path - but it's worth to fix

Re: [PATCH net] net: sched: fix unbalance in the error path of tca_action_flush()

2018-02-15 Thread Davide Caratti
On Thu, 2018-02-15 at 10:31 -0500, Jamal Hadi Salim wrote: > On 18-02-15 09:50 AM, Davide Caratti wrote: > > When tca_action_flush() calls the action walk() and gets an error, > > a successful call to nla_nest_start() is not followed by a call to > > nla_nest_cancel(). It's harmless, as the skb is

Re: [PATCH net] net: sched: fix unbalance in the error path of tca_action_flush()

2018-02-15 Thread Jamal Hadi Salim
On 18-02-15 09:50 AM, Davide Caratti wrote: When tca_action_flush() calls the action walk() and gets an error, a successful call to nla_nest_start() is not followed by a call to nla_nest_cancel(). It's harmless, as the skb is freed in the error path - but it's worth to fix this unbalance. Kind

[PATCH net] net: sched: fix unbalance in the error path of tca_action_flush()

2018-02-15 Thread Davide Caratti
When tca_action_flush() calls the action walk() and gets an error, a successful call to nla_nest_start() is not followed by a call to nla_nest_cancel(). It's harmless, as the skb is freed in the error path - but it's worth to fix this unbalance. Signed-off-by: Davide Caratti --- net/sched/act_ap