On Thu, 2018-02-15 at 10:31 -0500, Jamal Hadi Salim wrote: > On 18-02-15 09:50 AM, Davide Caratti wrote: > > When tca_action_flush() calls the action walk() and gets an error, > > a successful call to nla_nest_start() is not followed by a call to > > nla_nest_cancel(). It's harmless, as the skb is freed in the error > > path - but it's worth to fix this unbalance. > > Kind of pushing the boundaries saying this targets net tree - there is > no bug you are fixing (as you say the sk is freed). > Maybe it makes the code prettier ...
you are right, this fix is only cosmetic as long as the skb is no more used after walk() returns an error. It just triggered the doubt to me while I was reading the series that added support to ext_acks, and this is the followup. David, please apply to net-next (or drop it, at your convenience). thank you in advance, -- davide
