Re: [PATCH net] l2tp: fix configuration passed to setup_udp_tunnel_sock()

2016-06-08 Thread Guillaume Nault
On Tue, Jun 07, 2016 at 04:20:17PM -0700, David Miller wrote: > From: Guillaume Nault > Date: Mon, 6 Jun 2016 13:48:02 +0200 > > > @@ -1581,7 +1581,7 @@ int l2tp_tunnel_create(struct net *net, int fd, int > > version, u32 tunnel_id, u32 > > /* Mark socket as an encapsulation socket. See net/

Re: [PATCH net] l2tp: fix configuration passed to setup_udp_tunnel_sock()

2016-06-07 Thread David Miller
From: Guillaume Nault Date: Mon, 6 Jun 2016 13:48:02 +0200 > @@ -1581,7 +1581,7 @@ int l2tp_tunnel_create(struct net *net, int fd, int > version, u32 tunnel_id, u32 > /* Mark socket as an encapsulation socket. See net/ipv4/udp.c */ > tunnel->encap = encap; > if (encap == L2TP_E

[PATCH net] l2tp: fix configuration passed to setup_udp_tunnel_sock()

2016-06-06 Thread Guillaume Nault
Unused fields of udp_cfg must be all zeros. Otherwise setup_udp_tunnel_sock() fills ->gro_receive and ->gro_complete callbacks with garbage, eventually resulting in panic when used by udp_gro_receive(). [ 72.694123] BUG: unable to handle kernel paging request at 880033f87d78 [ 72.695518] I