On Tue, Jun 07, 2016 at 04:20:17PM -0700, David Miller wrote:
> From: Guillaume Nault <g.na...@alphalink.fr>
> Date: Mon, 6 Jun 2016 13:48:02 +0200
>
> > @@ -1581,7 +1581,7 @@ int l2tp_tunnel_create(struct net *net, int fd, int
> > version, u32 tunnel_id, u32
> > /* Mark socket as an encapsulation socket. See net/ipv4/udp.c */
> > tunnel->encap = encap;
> > if (encap == L2TP_ENCAPTYPE_UDP) {
> > - struct udp_tunnel_sock_cfg udp_cfg;
> > + struct udp_tunnel_sock_cfg udp_cfg = { NULL };
>
> This assumes that the first member of udp_tunnel_sock_cfg is, and will always
> be, a pointer.
>
> You could use a named initializer to make this better, but the cleanest way to
> deal with this is to use an empty initializer "{ }", or just plain memset()
> the thing to zero.
>
Indeed. I'll repost using "{ }" then.
