RE: [Intel-wired-lan] [PATCH net] ixgbe: fix potential RX buffer starvation for AF_XDP

2019-01-30 Thread Bowers, AndrewX
t; Subject: [Intel-wired-lan] [PATCH net] ixgbe: fix potential RX buffer > starvation for AF_XDP > > When the RX rings are created they are also populated with buffers so that > packets can be received. Usually these are kernel buffers, but for AF_XDP in > zero-copy mode, these are

Re: [Intel-wired-lan] [PATCH net] ixgbe: fix potential RX buffer starvation for AF_XDP

2019-01-30 Thread Jakub Kicinski
On Wed, 30 Jan 2019 15:16:15 +0100, Björn Töpel wrote: > Den ons 30 jan. 2019 kl 10:35 skrev Magnus Karlsson: > > > > On Tue, Jan 29, 2019 at 8:15 PM Jakub Kicinski wrote: > > > > > > I may not understand the problem fully, but isn't it kind of normal > > > that if you create a ring empty you'll n

Re: [Intel-wired-lan] [PATCH net] ixgbe: fix potential RX buffer starvation for AF_XDP

2019-01-30 Thread Magnus Karlsson
On Wed, Jan 30, 2019 at 3:16 PM Björn Töpel wrote: > > Den ons 30 jan. 2019 kl 10:35 skrev Magnus Karlsson > : > > > > On Tue, Jan 29, 2019 at 8:15 PM Jakub Kicinski > > wrote: > [...] > > > > > > I may not understand the problem fully, but isn't it kind of normal > > > that if you create a ring

Re: [Intel-wired-lan] [PATCH net] ixgbe: fix potential RX buffer starvation for AF_XDP

2019-01-30 Thread Björn Töpel
Den ons 30 jan. 2019 kl 10:35 skrev Magnus Karlsson : > > On Tue, Jan 29, 2019 at 8:15 PM Jakub Kicinski > wrote: [...] > > > > I may not understand the problem fully, but isn't it kind of normal > > that if you create a ring empty you'll never receive packets? And it > > should be reasonably eas

Re: [PATCH net] ixgbe: fix potential RX buffer starvation for AF_XDP

2019-01-30 Thread Magnus Karlsson
On Tue, Jan 29, 2019 at 8:15 PM Jakub Kicinski wrote: > > On Tue, 29 Jan 2019 15:03:50 +0100, Magnus Karlsson wrote: > > When the RX rings are created they are also populated with buffers so > > that packets can be received. Usually these are kernel buffers, but > > for AF_XDP in zero-copy mode, t

Re: [PATCH net] ixgbe: fix potential RX buffer starvation for AF_XDP

2019-01-29 Thread Jakub Kicinski
On Tue, 29 Jan 2019 15:03:50 +0100, Magnus Karlsson wrote: > When the RX rings are created they are also populated with buffers so > that packets can be received. Usually these are kernel buffers, but > for AF_XDP in zero-copy mode, these are user-space buffers and in this > case the application mi

[PATCH net] ixgbe: fix potential RX buffer starvation for AF_XDP

2019-01-29 Thread Magnus Karlsson
When the RX rings are created they are also populated with buffers so that packets can be received. Usually these are kernel buffers, but for AF_XDP in zero-copy mode, these are user-space buffers and in this case the application might not have sent down any buffers to the driver at this point. And