> -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Magnus Karlsson > Sent: Tuesday, January 29, 2019 6:04 AM > To: Karlsson, Magnus <magnus.karls...@intel.com>; Topel, Bjorn > <bjorn.to...@intel.com>; intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH net] ixgbe: fix potential RX buffer > starvation for AF_XDP > > When the RX rings are created they are also populated with buffers so that > packets can be received. Usually these are kernel buffers, but for AF_XDP in > zero-copy mode, these are user-space buffers and in this case the > application might not have sent down any buffers to the driver at this point. > And if no buffers are allocated at ring creation time, no packets can be > received and no interupts will be generated so the napi poll function that > allocates buffers to the rings will never get executed. > > To recitfy this, we kick the NAPI context of any queue with an attached > AF_XDP zero-copy socket in two places in the code. Once after an XDP > program has loaded and once after the umem is registered. This take care of > both cases: XDP program gets loaded first then AF_XDP socket is created, > and the reverse, AF_XDP socket is created first, then XDP program is loaded. > > Fixes: d0bcacd0a130 ("ixgbe: add AF_XDP zero-copy Rx support") > Signed-off-by: Magnus Karlsson <magnus.karls...@intel.com> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 12 +++++++++++- > drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 12 ++++++++++-- > 2 files changed, 21 insertions(+), 3 deletions(-)
Tested-by: Andrew Bowers <andrewx.bow...@intel.com>
