On 6/17/15, 10:31 AM, Alexander Duyck wrote:
I'd say go with something closer to the original patch, but flip the
logic like you have here, and lose the "|=" in favor of an "=" since
you are either sending a message with 0 or NLM_F_APPEND.
Anyway that is just my $.02.
agreed,
thanks alex,
On 06/17/2015 09:20 AM, roopa wrote:
On 6/17/15, 8:35 AM, Alexander Duyck wrote:
@@ -1189,8 +1190,9 @@ int fib_table_insert(struct fib_table *tb, struct
fib_config *cfg)
fib_release_info(fi_drop);
if (state & FA_S_ACCESSED)
rt_cache_flush(cfg->
On 6/17/15, 8:35 AM, Alexander Duyck wrote:
@@ -1189,8 +1190,9 @@ int fib_table_insert(struct fib_table *tb, struct
fib_config *cfg)
fib_release_info(fi_drop);
if (state & FA_S_ACCESSED)
rt_cache_flush(cfg->fc_nlinfo.nl_net);
+
On 06/17/2015 07:50 AM, roopa wrote:
On 6/17/15, 12:50 AM, Scott Feldman wrote:
On Tue, Jun 16, 2015 at 9:11 AM, Roopa Prabhu
wrote:
[snip]
@@ -1203,6 +1204,8 @@ int fib_table_insert(struct fib_table *tb,
struct fib_config *cfg)
if (!(cfg->fc_nlflags & NLM_F_APPEND))
On 6/17/15, 12:50 AM, Scott Feldman wrote:
On Tue, Jun 16, 2015 at 9:11 AM, Roopa Prabhu wrote:
[snip]
@@ -1203,6 +1204,8 @@ int fib_table_insert(struct fib_table *tb, struct
fib_config *cfg)
if (!(cfg->fc_nlflags & NLM_F_APPEND))
fa = fa_first;
+
On Tue, Jun 16, 2015 at 9:11 AM, Roopa Prabhu wrote:
[snip]
> @@ -1203,6 +1204,8 @@ int fib_table_insert(struct fib_table *tb, struct
> fib_config *cfg)
>
> if (!(cfg->fc_nlflags & NLM_F_APPEND))
> fa = fa_first;
> + else
> +
On 6/16/15, 9:11 AM, Roopa Prabhu wrote:
From: Roopa Prabhu
This patch adds NLM_F_APPEND flag to struct nlmsg_hdr->nlmsg_flags
in newroute notifications if the route add was an append.
(This is similar to how NLM_F_REPLACE is already part of new
route replace notifications today)
This helps us
From: Roopa Prabhu
This patch adds NLM_F_APPEND flag to struct nlmsg_hdr->nlmsg_flags
in newroute notifications if the route add was an append.
(This is similar to how NLM_F_REPLACE is already part of new
route replace notifications today)
This helps userspace determine if the route add operatio
