On Tue, Jun 16, 2015 at 9:11 AM, Roopa Prabhu <ro...@cumulusnetworks.com> wrote:
[snip]
> @@ -1203,6 +1204,8 @@ int fib_table_insert(struct fib_table *tb, struct
> fib_config *cfg)
>
> if (!(cfg->fc_nlflags & NLM_F_APPEND))
> fa = fa_first;
> + else
> + nlflags |= NLM_F_APPEND;
> }
The if and else parts above don't seem logically related. Maybe you
could initialize nlflags as:
unsigned int nlflags = cfg->fc_nlflags & (NLM_F_REPLACE|NLM_F_APPEND);
And then pass rtmsg_fib(..., nlflags) to avoid the flag test/set?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
