Re: [PATCH net] ip6_tunnel: remove unreachable ICMP_REDIRECT code

2017-05-09 Thread Hangbin Liu
On Mon, May 08, 2017 at 01:26:48PM -0700, Cong Wang wrote: > On Mon, May 8, 2017 at 4:11 AM, Hangbin Liu wrote: > > After call ip6_tnl_err(), the rel_type will be ether ICMPV6_DEST_UNREACH > > or ICMPV6_PKT_TOOBIG. We will never reach ICMP_REDIRECT. So remove it. > > Are you sure we really don't

Re: [PATCH net] ip6_tunnel: remove unreachable ICMP_REDIRECT code

2017-05-08 Thread Hangbin Liu
2017-05-09 3:59 GMT+08:00 David Miller : > From: Hangbin Liu > Date: Mon, 8 May 2017 19:11:03 +0800 > >> After call ip6_tnl_err(), the rel_type will be ether ICMPV6_DEST_UNREACH >> or ICMPV6_PKT_TOOBIG. We will never reach ICMP_REDIRECT. So remove it. >> >> Signed-off-by: Hangbin Liu > > Your pa

Re: [PATCH net] ip6_tunnel: remove unreachable ICMP_REDIRECT code

2017-05-08 Thread Cong Wang
On Mon, May 8, 2017 at 4:11 AM, Hangbin Liu wrote: > After call ip6_tnl_err(), the rel_type will be ether ICMPV6_DEST_UNREACH > or ICMPV6_PKT_TOOBIG. We will never reach ICMP_REDIRECT. So remove it. Are you sure we really don't need to handle NDISC_REDIRECT here? I can't find anything in RFC 247

Re: [PATCH net] ip6_tunnel: remove unreachable ICMP_REDIRECT code

2017-05-08 Thread David Miller
From: Hangbin Liu Date: Mon, 8 May 2017 19:11:03 +0800 > After call ip6_tnl_err(), the rel_type will be ether ICMPV6_DEST_UNREACH > or ICMPV6_PKT_TOOBIG. We will never reach ICMP_REDIRECT. So remove it. > > Signed-off-by: Hangbin Liu Your patches here, all seemingly due to "visual inspection"

[PATCH net] ip6_tunnel: remove unreachable ICMP_REDIRECT code

2017-05-08 Thread Hangbin Liu
After call ip6_tnl_err(), the rel_type will be ether ICMPV6_DEST_UNREACH or ICMPV6_PKT_TOOBIG. We will never reach ICMP_REDIRECT. So remove it. Signed-off-by: Hangbin Liu --- net/ipv6/ip6_tunnel.c | 5 - 1 file changed, 5 deletions(-) diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel