From: Hangbin Liu <liuhang...@gmail.com> Date: Mon, 8 May 2017 19:11:03 +0800
> After call ip6_tnl_err(), the rel_type will be ether ICMPV6_DEST_UNREACH > or ICMPV6_PKT_TOOBIG. We will never reach ICMP_REDIRECT. So remove it. > > Signed-off-by: Hangbin Liu <liuhang...@gmail.com> Your patches here, all seemingly due to "visual inspection", are starting to really, truly, irritate me. Half of them are unnecessary, some are completely buggy. I have to review them and audit them very satrictly as a result, and this takes up an unnecessarily large amount of my time. Therefore, I'm basically going to stop looking at your changes _unless_ you can show that you specifically tested and exercised all of the code paths you are changing. I am sorry to have to do this, but the value to effort ratio of reviewing and integrating your changes is quite poor.
