> On Oct 20, 2020, at 5:19 PM, Jakub Kicinski wrote:
>
> On Tue, 20 Oct 2020 17:07:38 -0500 Lijun Pan wrote:
>>> Please read my reply carefully.
>>>
>>> What's the call path that leads to the address being wrong? If you set
>>> the address via ifconfig it will call ibmvnic_set_mac() of the dr
On Tue, 20 Oct 2020 17:07:38 -0500 Lijun Pan wrote:
> > Please read my reply carefully.
> >
> > What's the call path that leads to the address being wrong? If you set
> > the address via ifconfig it will call ibmvnic_set_mac() of the driver.
> > ibmvnic_set_mac() does the copy.
> >
> > But it doe
> On Oct 20, 2020, at 5:07 PM, Lijun Pan wrote:
>
>
>
>> On Oct 20, 2020, at 4:33 PM, Jakub Kicinski wrote:
>>
>> On Tue, 20 Oct 2020 16:18:04 -0500 Lijun Pan wrote:
On Oct 19, 2020, at 7:11 PM, Jakub Kicinski wrote:
On Thu, 15 Oct 2020 23:57:15 -0500 Lijun Pan wrote:
>>
> On Oct 20, 2020, at 4:33 PM, Jakub Kicinski wrote:
>
> On Tue, 20 Oct 2020 16:18:04 -0500 Lijun Pan wrote:
>>> On Oct 19, 2020, at 7:11 PM, Jakub Kicinski wrote:
>>>
>>> On Thu, 15 Oct 2020 23:57:15 -0500 Lijun Pan wrote:
After mac address change request completes successfully, the
On Tue, 20 Oct 2020 16:18:04 -0500 Lijun Pan wrote:
> > On Oct 19, 2020, at 7:11 PM, Jakub Kicinski wrote:
> >
> > On Thu, 15 Oct 2020 23:57:15 -0500 Lijun Pan wrote:
> >> After mac address change request completes successfully, the new mac
> >> address need to be saved to adapter->mac_addr as
> On Oct 19, 2020, at 7:11 PM, Jakub Kicinski wrote:
>
> On Thu, 15 Oct 2020 23:57:15 -0500 Lijun Pan wrote:
>> After mac address change request completes successfully, the new mac
>> address need to be saved to adapter->mac_addr as well as
>> netdev->dev_addr. Otherwise, adapter->mac_addr sti
On Thu, 15 Oct 2020 23:57:15 -0500 Lijun Pan wrote:
> After mac address change request completes successfully, the new mac
> address need to be saved to adapter->mac_addr as well as
> netdev->dev_addr. Otherwise, adapter->mac_addr still holds old
> data.
Do you observe this in practice? Can you sh
After mac address change request completes successfully, the new mac
address need to be saved to adapter->mac_addr as well as
netdev->dev_addr. Otherwise, adapter->mac_addr still holds old
data.
Fixes: 62740e97881c("net/ibmvnic: Update MAC address settings after adapter
reset")
Signed-off-by: Lij
