On Thu, 15 Oct 2020 23:57:15 -0500 Lijun Pan wrote: > After mac address change request completes successfully, the new mac > address need to be saved to adapter->mac_addr as well as > netdev->dev_addr. Otherwise, adapter->mac_addr still holds old > data.
Do you observe this in practice? Can you show us which path in particular you see this happen on? AFAICS ibmvnic_set_mac() copies the new MAC addr into adapter->mac_addr before making a request. If anything is wrong here is that it does so regardless if MAC addr is valid. > Fixes: 62740e97881c("net/ibmvnic: Update MAC address settings after adapter > reset") ^ missing space here > Signed-off-by: Lijun Pan <l...@linux.ibm.com>