Re: [PATCH ethtool] ethtool: qsfp: fix special value comparison

2019-03-14 Thread John W. Linville
On Thu, Mar 14, 2019 at 07:33:16PM +0100, Michal Kubecek wrote: > One of the warnings gcc issues when building ethtool with -Wall seems to > point to an actual problem: > > qsfp.c: In function 'sff8636_show_dom': > qsfp.c:709:57: warning: comparison is always false due to limited range of > data

[PATCH ethtool] ethtool: qsfp: fix special value comparison

2019-03-14 Thread Michal Kubecek
One of the warnings gcc issues when building ethtool with -Wall seems to point to an actual problem: qsfp.c: In function 'sff8636_show_dom': qsfp.c:709:57: warning: comparison is always false due to limited range of data type [-Wtype-limits] if ((sd.sfp_temp[MCURR] == 0x0) || (sd.sfp_temp[MCURR