Re: [PATCH bpf-next v3 0/5] net: xdp: refactor XDP program queries

2019-06-12 Thread Jonathan Lemon
On 11 Jun 2019, at 0:24, Björn Töpel wrote: > On 2019-06-11 00:24, Jakub Kicinski wrote: >> On Mon, 10 Jun 2019 18:02:29 +0200, Björn Töpel wrote: >>> Jakub, what's your thoughts on the special handling of XDP offloading? >>> Maybe it's just overkill? Just allocate space for the offloaded >>> p

Re: [PATCH bpf-next v3 0/5] net: xdp: refactor XDP program queries

2019-06-11 Thread Björn Töpel
On 2019-06-11 19:22, Jakub Kicinski wrote: Three progs? Are we planning to allow SKB and DRV at the same time? No! :-) One prog and flags looked fairly reasonable to me. Flags can even be a u8. The offload prog can continue to live in the driver. Ok, I'll take that route (only adding a u

Re: [PATCH bpf-next v3 0/5] net: xdp: refactor XDP program queries

2019-06-11 Thread Jakub Kicinski
On Tue, 11 Jun 2019 09:24:41 +0200, Björn Töpel wrote: > On 2019-06-11 00:24, Jakub Kicinski wrote: > > On Mon, 10 Jun 2019 18:02:29 +0200, Björn Töpel wrote: > >> Jakub, what's your thoughts on the special handling of XDP offloading? > >> Maybe it's just overkill? Just allocate space for the off

Re: [PATCH bpf-next v3 0/5] net: xdp: refactor XDP program queries

2019-06-11 Thread Toke Høiland-Jørgensen
Björn Töpel writes: > On 2019-06-11 00:24, Jakub Kicinski wrote: >> On Mon, 10 Jun 2019 18:02:29 +0200, Björn Töpel wrote: >>> Jakub, what's your thoughts on the special handling of XDP offloading? >>> Maybe it's just overkill? Just allocate space for the offloaded >>> program regardless support

Re: [PATCH bpf-next v3 0/5] net: xdp: refactor XDP program queries

2019-06-11 Thread Björn Töpel
On 2019-06-11 00:24, Jakub Kicinski wrote: On Mon, 10 Jun 2019 18:02:29 +0200, Björn Töpel wrote: Jakub, what's your thoughts on the special handling of XDP offloading? Maybe it's just overkill? Just allocate space for the offloaded program regardless support or not? Also, please review the dev_

Re: [PATCH bpf-next v3 0/5] net: xdp: refactor XDP program queries

2019-06-10 Thread Jakub Kicinski
On Mon, 10 Jun 2019 18:02:29 +0200, Björn Töpel wrote: > Jakub, what's your thoughts on the special handling of XDP offloading? > Maybe it's just overkill? Just allocate space for the offloaded > program regardless support or not? Also, please review the > dev_xdp_support_offload() addition into th

[PATCH bpf-next v3 0/5] net: xdp: refactor XDP program queries

2019-06-10 Thread Björn Töpel
Here's yet another attempt tomove the XDP_QUERY_PROG{,_HW} code out from the drivers to generic netdev code. I took a bit different approach with the v3. In this revision I introduced to a new netdev_xdp structure that tracks the XDP programs, and instead of sharing the xdp_prog member between DRV