On Mon, 10 Jun 2019 18:02:29 +0200, Björn Töpel wrote: > Jakub, what's your thoughts on the special handling of XDP offloading? > Maybe it's just overkill? Just allocate space for the offloaded > program regardless support or not? Also, please review the > dev_xdp_support_offload() addition into the nfp code.
I'm not a huge fan of the new approach - it adds a conditional move, dereference and a cache line reference to the fast path :( I think it'd be fine to allocate entries for all 3 types, but the potential of slowing down DRV may not be a good thing in a refactoring series.
