Re: [PATCH RESEND 2/2] update sunrpc to use in-kernel sockets API

2006-08-09 Thread David Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Wed, 09 Aug 2006 10:34:38 -0700 > [SUNRPC]: Remove the unnecessary check for highmem in xs_sendpages() > and call kernel_sendpage() directly. > > Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED]> Applied to net-2.6.19, thanks a lot Sridhar. -

Re: [PATCH RESEND 2/2] update sunrpc to use in-kernel sockets API

2006-08-09 Thread Sridhar Samudrala
On Tue, 2006-08-08 at 23:16 -0400, Trond Myklebust wrote: > On Tue, 2006-08-08 at 17:09 -0700, David Miller wrote: > > > Trond, I think the highmem check in xs_sendpages() is completely > > bogus, do you mind if we remove it? :-) > > > > The socket layer will properly check the device to make sur

Re: [PATCH RESEND 2/2] update sunrpc to use in-kernel sockets API

2006-08-08 Thread Trond Myklebust
On Tue, 2006-08-08 at 17:09 -0700, David Miller wrote: > Trond, I think the highmem check in xs_sendpages() is completely > bogus, do you mind if we remove it? :-) > > The socket layer will properly check the device to make sure it > can handle highmem pages, and if not it will copy the data into

Re: [PATCH RESEND 2/2] update sunrpc to use in-kernel sockets API

2006-08-08 Thread David Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Tue, 08 Aug 2006 10:19:51 -0700 > We cannot do this as xs_sendpages() doesn't like to use sendpage() > with highmem pages and has the following check before making the > actual call. > /* Hmm... We might be dealing with highmem page

Re: [PATCH RESEND 2/2] update sunrpc to use in-kernel sockets API

2006-08-08 Thread Sridhar Samudrala
On Mon, 2006-08-07 at 20:59 -0700, David Miller wrote: > From: Sridhar Samudrala <[EMAIL PROTECTED]> > Date: Mon, 07 Aug 2006 16:00:32 -0700 > > > Update sunrpc to use in-kernel sockets API. > > > > Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED]> > > Acked-by: James Morris <[EMAIL PROTECTED]

Re: [PATCH RESEND 2/2] update sunrpc to use in-kernel sockets API

2006-08-07 Thread David Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Mon, 07 Aug 2006 16:00:32 -0700 > Update sunrpc to use in-kernel sockets API. > > Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED]> > Acked-by: James Morris <[EMAIL PROTECTED]> Applied, thanks. > @@ -207,7 +207,7 @@ static inline int xs_sendp

[PATCH RESEND 2/2] update sunrpc to use in-kernel sockets API

2006-08-07 Thread Sridhar Samudrala
Update sunrpc to use in-kernel sockets API. Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> --- net/sunrpc/svcsock.c | 38 ++ net/sunrpc/xprtsock.c |8 2 files changed, 18 insertions(+), 28 delet