Re: [PATCH RESEND 2/2] update sunrpc to use in-kernel sockets API

[Sridhar Samudrala]

On Mon, 2006-08-07 at 20:59 -0700, David Miller wrote:
> From: Sridhar Samudrala <[EMAIL PROTECTED]>
> Date: Mon, 07 Aug 2006 16:00:32 -0700
> 
> > Update sunrpc to use in-kernel sockets API.
> > 
> > Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED]>
> > Acked-by: James Morris <[EMAIL PROTECTED]>
> 
> Applied, thanks.
> 
> > @@ -207,7 +207,7 @@ static inline int xs_sendpages(struct so
> >             base &= ~PAGE_CACHE_MASK;
> >     }
> >  
> > -   sendpage = sock->ops->sendpage ? : sock_no_sendpage;
> > +   sendpage = kernel_sendpage;
> >     do {
> >             int flags = XS_SENDMSG_FLAGS;
> >  
> 
> Seemingly this chunk could be simplified further, by
> just invoking kernel_sendpage() directly?

We cannot do this as xs_sendpages() doesn't like to use sendpage()
with highmem pages and has the following check before making the
actual call.
                /* Hmm... We might be dealing with highmem pages */
                if (PageHighMem(*ppage))
                        sendpage = sock_no_sendpage;
                err = sendpage(sock, *ppage, base, len, flags);

Thanks
Sridhar


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html