Re: [EXT] Re: [PATCH NET] net: atlantic: Use readx_poll_timeout() for large timeout

2020-08-20 Thread Igor Russkikh
>> implemented a read callback with an udelay(1U). This fails to >> compile on ARM because the delay is >1ms. I doubt that it is needed to >> spin for 10ms even if possible on x86. >> >> >From looking at the code, the context appears to be preemptible so > using >> usleep() should work and av

Re: [PATCH NET] net: atlantic: Use readx_poll_timeout() for large timeout

2020-08-19 Thread David Miller
From: Sebastian Andrzej Siewior Date: Tue, 18 Aug 2020 18:14:39 +0200 > Commit >8dcf2ad39fdb2 ("net: atlantic: add hwmon getter for MAC temperature") > > implemented a read callback with an udelay(1U). This fails to > compile on ARM because the delay is >1ms. I doubt that it is needed to

Re: [PATCH NET] net: atlantic: Use readx_poll_timeout() for large timeout

2020-08-19 Thread Guenter Roeck
On Tue, Aug 18, 2020 at 06:14:39PM +0200, Sebastian Andrzej Siewior wrote: > Commit >8dcf2ad39fdb2 ("net: atlantic: add hwmon getter for MAC temperature") > > implemented a read callback with an udelay(1U). This fails to > compile on ARM because the delay is >1ms. I doubt that it is needed

[PATCH NET] net: atlantic: Use readx_poll_timeout() for large timeout

2020-08-18 Thread Sebastian Andrzej Siewior
Commit 8dcf2ad39fdb2 ("net: atlantic: add hwmon getter for MAC temperature") implemented a read callback with an udelay(1U). This fails to compile on ARM because the delay is >1ms. I doubt that it is needed to spin for 10ms even if possible on x86. >From looking at the code, the context ap