>> implemented a read callback with an udelay(10000U). This fails to
>> compile on ARM because the delay is >1ms. I doubt that it is needed to
>> spin for 10ms even if possible on x86.
>>
>> >From looking at the code, the context appears to be preemptible so
> using
>> usleep() should work and avoid busy spinning.
>>
>> Use readx_poll_timeout() in the poll loop.
>>
>> Cc: Mark Starovoytov <mstarovoi...@marvell.com>
>> Cc: Igor Russkikh <irussk...@marvell.com>
>> Signed-off-by: Sebastian Andrzej Siewior <sebast...@breakpoint.cc>
>
> Fixes: 8dcf2ad39fdb2 ("net: atlantic: add hwmon getter for MAC
> temperature")
> Acked-by: Guenter Roeck <li...@roeck-us.net>
>
> As in: This patch does not cause any additional trouble and will fix the
> observed compile failure. However, the submitter of 8dcf2ad39fdb2 might
> consider adding a mutex either into hw_atl_b0_get_mac_temp() or into
> the calling code.
Hi Sebastian, Guenter, thanks for catching and taking care of this,
Looks good for me so far.
>> Could someone with hardware please verify it? It compiles, yes.
>>
We'll verify this on our side, sure.
Regards,
Igor
