Re: [PATCH 4/5] net/packet: fix overflow in check for tp_reserve

2017-03-28 Thread Willem de Bruijn
On Tue, Mar 28, 2017 at 11:11 AM, Andrey Konovalov wrote: > On Tue, Mar 28, 2017 at 5:00 PM, Willem de Bruijn > wrote: >> On Tue, Mar 28, 2017 at 10:00 AM, Andrey Konovalov >> wrote: >>> When calculating po->tp_hdrlen + po->tp_reserve the result can overflow. >>> >>> Fix by checking that tp_rese

Re: [PATCH 4/5] net/packet: fix overflow in check for tp_reserve

2017-03-28 Thread Andrey Konovalov
On Tue, Mar 28, 2017 at 5:00 PM, Willem de Bruijn wrote: > On Tue, Mar 28, 2017 at 10:00 AM, Andrey Konovalov > wrote: >> When calculating po->tp_hdrlen + po->tp_reserve the result can overflow. >> >> Fix by checking that tp_reserve <= INT_MAX on assign. >> >> This also takes cared of an overflow

Re: [PATCH 4/5] net/packet: fix overflow in check for tp_reserve

2017-03-28 Thread Willem de Bruijn
On Tue, Mar 28, 2017 at 10:00 AM, Andrey Konovalov wrote: > When calculating po->tp_hdrlen + po->tp_reserve the result can overflow. > > Fix by checking that tp_reserve <= INT_MAX on assign. > > This also takes cared of an overflow when calculating > macoff = TPACKET_ALIGN(po->tp_hdrlen) + 16 + p

[PATCH 4/5] net/packet: fix overflow in check for tp_reserve

2017-03-28 Thread Andrey Konovalov
When calculating po->tp_hdrlen + po->tp_reserve the result can overflow. Fix by checking that tp_reserve <= INT_MAX on assign. This also takes cared of an overflow when calculating macoff = TPACKET_ALIGN(po->tp_hdrlen) + 16 + po->tp_reserve snaplen = skb->len macoff + snaplen since macoff ~ IN