Re: [PATCH 2/2] net: qcom/emac: enable flow control if requested

2016-11-01 Thread Timur Tabi
On 11/01/2016 01:30 PM, Timur Tabi wrote: + if (!phydev->pause && phydev->asym_pause) + mac |= TXFC; I think this might be wrong, and nb8800_pause_config() has it right. This should be: if (!phydev->pause != !phydev->asym_pause) which is a logical-xor. Do you co

Re: [PATCH 2/2] net: qcom/emac: enable flow control if requested

2016-11-01 Thread Florian Fainelli
On 11/01/2016 11:30 AM, Timur Tabi wrote: > If the PHY has been configured to allow pause frames, then the MAC > should be configured to generate and/or accept those frames. > > Signed-off-by: Timur Tabi Reviewed-by: Florian Fainelli -- Florian

[PATCH 2/2] net: qcom/emac: enable flow control if requested

2016-11-01 Thread Timur Tabi
If the PHY has been configured to allow pause frames, then the MAC should be configured to generate and/or accept those frames. Signed-off-by: Timur Tabi --- drivers/net/ethernet/qualcomm/emac/emac-mac.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/e