From: Christoph Hellwig <[EMAIL PROTECTED]>
Date: Fri, 7 Jul 2006 11:09:57 +0200
> dev_alloc_skb is designated for RX descriptors, not TX. (Some drivers
> use it for the latter anyway, but that's a different story)
>
> Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
Also applied, thanks a
In message <[EMAIL PROTECTED]>,David Miller writes:
>From: Christoph Hellwig <[EMAIL PROTECTED]>
>Date: Thu, 13 Jul 2006 22:36:16 +0200
>> - drivers/atm/{idt77252.c, nicstar.c}, drivers/usb/atm/usbatm.c:
>> These use private skb queues and do odd things. I can't see
>> any point for usi
On Fri, Jul 14, 2006 at 10:27:27AM +0300, Samuel Ortiz wrote:
> > The patchkit for this is at http://verein.lst.de/~hch/patches.skb.tgz, it
> > includes the first two cleanup patches I posted previously (Any plans
> > to put them in?), a patch to move __dev_alloc_skb out of line because
> > otherwi
On Thu, Jul 13, 2006 at 10:36:16PM +0200, Christoph Hellwig wrote:
> - net/irda/*:
> They allocate the skb in protocol code for TX. Should probably
> do a normal alloc_skb like all the other protocol code.
Agreed. I will come up with a patch replacing all the useless dev_alloc_skb()
c
From: Christoph Hellwig <[EMAIL PROTECTED]>
Date: Thu, 13 Jul 2006 23:29:19 +0200
> > What's the new name? For sanity, don't reuse the name dev_alloc_skb.
>
> dev_alloc_skb. It's the by far sanest name for it, while the old
> usage without dev argument was misleading.
As much as I would like to
> What's the new name? For sanity, don't reuse the name dev_alloc_skb.
dev_alloc_skb. It's the by far sanest name for it, while the old
usage without dev argument was misleading.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
Mor
On Thu, 13 Jul 2006 22:36:16 +0200
Christoph Hellwig <[EMAIL PROTECTED]> wrote:
> On Sat, Jul 08, 2006 at 01:37:38PM -0700, David Miller wrote:
> > > My plan is to give dev_alloc_skb a struct netdevice * argument and
> > > introduce a alloc_netdev_node so the driver can tell what node the
> > > de
From: Christoph Hellwig <[EMAIL PROTECTED]>
Date: Thu, 13 Jul 2006 22:36:16 +0200
> - drivers/atm/{idt77252.c, nicstar.c}, drivers/usb/atm/usbatm.c:
> These use private skb queues and do odd things. I can't see
> any point for using dev_alloc_skb with it's additional headroom
>
On Thu, 13 Jul 2006 22:36:16 +0200 Christoph Hellwig wrote:
...
>
> I gave converting the dev_alloc_skb prototype everywhere a spin and it
> doesn't look too bad. There's only a few places that don't have a
> netdevice at hand, and all these look bogus:
>
...
> - drivers/infiniband/hw/ipath/i
On Sat, Jul 08, 2006 at 01:37:38PM -0700, David Miller wrote:
> > My plan is to give dev_alloc_skb a struct netdevice * argument and
> > introduce a alloc_netdev_node so the driver can tell what node the
> > device is on. This gives a significant speedup for cell. I already
> > have this implemen
From: Christoph Hellwig <[EMAIL PROTECTED]>
Date: Sat, 8 Jul 2006 12:48:12 +0200
> My plan is to give dev_alloc_skb a struct netdevice * argument and
> introduce a alloc_netdev_node so the driver can tell what node the
> device is on. This gives a significant speedup for cell. I already
> have t
On Fri, Jul 07, 2006 at 04:55:27PM -0700, David Miller wrote:
> From: Stephen Hemminger <[EMAIL PROTECTED]>
> Date: Fri, 7 Jul 2006 15:52:55 -0700
>
> > What is the point of dev_alloc_skb anyway? all it does is add header space.
>
> In stone-age times it actually had specific semantics, but yes t
David Miller <[EMAIL PROTECTED]> wrote:
>> What is the point of dev_alloc_skb anyway? all it does is add header space.
>
> In stone-age times it actually had specific semantics, but yes today
> it is just a synonym.
Does anyone still need those 16 bytes of header space?
Cheers,
--
Visit Openswa
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Fri, 7 Jul 2006 15:52:55 -0700
> What is the point of dev_alloc_skb anyway? all it does is add header space.
In stone-age times it actually had specific semantics, but yes today
it is just a synonym.
It's going to be hard to get rid of it, every
On Fri, 7 Jul 2006 11:09:57 +0200
Christoph Hellwig <[EMAIL PROTECTED]> wrote:
> dev_alloc_skb is designated for RX descriptors, not TX. (Some drivers
> use it for the latter anyway, but that's a different story)
>
>
> Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
>
> Index: linux-2.6/i
dev_alloc_skb is designated for RX descriptors, not TX. (Some drivers
use it for the latter anyway, but that's a different story)
Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
Index: linux-2.6/include/linux/skbuff.h
===
---
16 matches
Mail list logo
