From: Christoph Hellwig <[EMAIL PROTECTED]>
Date: Thu, 13 Jul 2006 22:36:16 +0200
> - drivers/atm/{idt77252.c, nicstar.c}, drivers/usb/atm/usbatm.c:
> These use private skb queues and do odd things. I can't see
> any point for using dev_alloc_skb with it's additional headroom
> reservation here.
> - drivers/isdn/<everything> :
> These don't even have a netdevice! Also I can't see why they
> need the headroom.
> - drivers/net/{ppp_async.c,drivers/net/ppp_async.c}:
> They take data from the underlying tty device. Because of that
> there's not point for he additional headroom.
> - net/irda/*:
> They allocate the skb in protocol code for TX. Should probably
> do a normal alloc_skb like all the other protocol code.
> - drivers/infiniband/hw/ipath/ipath_driver.c:
> Uses skbbuffs in a driver that has absolutely nothing to do
> with networking. Duh..
Any of these cases that DMA into the skb allocated will need
the headroom, as explained by the PowerPC folks.
I can see how PPP just copies into the skb, but some of the
ISDN bits will be doing DMA won't they?
I agree that IRDA's transmit side shouldn't be calling
dev_alloc_skb.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
