Re: [PATCH 1115/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread David Miller
From: Pavel Machek Date: Tue, 2 Aug 2016 19:47:33 +0200 > But that does not make me like the series. And yes, hiding backdoor > in one of those would be way too easy... This is one of the worst patch series submissions in history. At vger.kernel.org postmaster I just spent 45 minutes dealing wit

Re: [PATCH 1115/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Pavel Machek
On Tue 2016-08-02 09:29:27, Eric W. Biederman wrote: > Baole Ni writes: > > > I find that the developers often just specified the numeric value > > when calling a macro which is defined with a parameter for access > > permission. > > As we know, these numeric value for access permission have had

Re: [PATCH 1115/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Eric W. Biederman
Baole Ni writes: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using macro can improve the

[PATCH 1115/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of