Re: [PATCH] xfrm: return error when esp offload is requested and not supported

2021-03-19 Thread Sabrina Dubroca
2021-03-17, 09:42:43 +0100, Antony Antony wrote: > Hi, > > On Mon, Mar 15, 2021 at 16:29:59 +0100, Sabrina Dubroca wrote: > > 2021-03-15, 11:43:50 +0100, Steffen Klassert wrote: > > > On Wed, Mar 10, 2021 at 10:36:11AM +0100, Antony Antony wrote: > > > > When ESP offload is not supported by the de

Re: [PATCH] xfrm: return error when esp offload is requested and not supported

2021-03-17 Thread Antony Antony
Hi, On Mon, Mar 15, 2021 at 16:29:59 +0100, Sabrina Dubroca wrote: > 2021-03-15, 11:43:50 +0100, Steffen Klassert wrote: > > On Wed, Mar 10, 2021 at 10:36:11AM +0100, Antony Antony wrote: > > > When ESP offload is not supported by the device return an error, > > > -EINVAL, instead of silently igno

Re: [PATCH] xfrm: return error when esp offload is requested and not supported

2021-03-15 Thread Sabrina Dubroca
2021-03-15, 11:43:50 +0100, Steffen Klassert wrote: > On Wed, Mar 10, 2021 at 10:36:11AM +0100, Antony Antony wrote: > > When ESP offload is not supported by the device return an error, > > -EINVAL, instead of silently ignoring it, creating a SA without offload, > > and returning success. > > > >

Re: [PATCH] xfrm: return error when esp offload is requested and not supported

2021-03-15 Thread Steffen Klassert
On Wed, Mar 10, 2021 at 10:36:11AM +0100, Antony Antony wrote: > When ESP offload is not supported by the device return an error, > -EINVAL, instead of silently ignoring it, creating a SA without offload, > and returning success. > > with this fix ip x s a would return > RTNETLINK answers: Invalid

[PATCH] xfrm: return error when esp offload is requested and not supported

2021-03-10 Thread Antony Antony
When ESP offload is not supported by the device return an error, -EINVAL, instead of silently ignoring it, creating a SA without offload, and returning success. with this fix ip x s a would return RTNETLINK answers: Invalid argument Also, return an error, -EINVAL, when CONFIG_XFRM_OFFLOAD is not