On Wed, Mar 10, 2021 at 10:36:11AM +0100, Antony Antony wrote:
> When ESP offload is not supported by the device return an error,
> -EINVAL, instead of silently ignoring it, creating a SA without offload,
> and returning success.
>
> with this fix ip x s a would return
> RTNETLINK answers: Invalid argument
>
> Also, return an error, -EINVAL, when CONFIG_XFRM_OFFLOAD is
> not defined and the user is trying to create an SA with the offload.
>
> Fixes: d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API")
> Signed-off-by: Antony Antony <antony.ant...@secunet.com>
I feal a bit unease about this one. When we designed the offloading
API, we decided to fallback to software if HW offload is not available.
Not sure if that was a good idea, but changing this would also change
the userspace ABI. So if we change this, we should at least not
consider it as a fix because it would be backported to -stable
in that case. Thoughts?
