It doesn't look like you need a test report, but here's one anyway...
I grabbed the patch series from git and am running it successfully
right now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.
Al Viro <[EMAIL PROTECTED]> :
[...]
> Point taken...
>
> * kill multibyte bitfields
> * annotate
> * add missing conversions
> * fix a couple of brainos in zerocopy stuff (fortunately, it's ifdef'ed out)
>
> Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Thanks a lot. After the usual xmas delay, spl
On Wed, Dec 26, 2007 at 12:21:35AM +0100, Francois Romieu wrote:
> -> some descriptor bits are now declared with an explicit endianness
>while others are not (whence "u16 rsr" where "__le16 rsr" whould
>have fit). Both are fine but it would not hurt to stick with one
>convention in a gi
Al Viro <[EMAIL PROTECTED]> :
[...]
> > Can we avoid using cpu_to_leXY here for consistency sake within the driver
> > (and among different drivers as well) ?
>
> ???
I admit that it is a bit late for the Xmas wishlist. Compare it with:
@@ -1409,31 +1409,33 @@ static int velocity_rx_srv(struct v
On Tue, Dec 25, 2007 at 11:43:33PM +0100, Francois Romieu wrote:
> > +#define DESC_OWNER cpu_to_le16(0x8000)
> > +
>
> DESC_OWNER does not seem to be used.
*nod*
That should be removed.
> [...]
> > +enum {
> > + RX_INTEN = __constant_cpu_to_le16(0x8000)
> > +};
>
> Can we avoid using cpu_to_
Al Viro <[EMAIL PROTECTED]> :
[...]
> diff --git a/drivers/net/via-velocity.h b/drivers/net/via-velocity.h
> index aa91796..e0ec5d4 100644
> --- a/drivers/net/via-velocity.h
> +++ b/drivers/net/via-velocity.h
> @@ -196,26 +196,29 @@
> * Receive descriptor
> */
>
> +#define DESC_OWNER cpu_to
* killed multibyte bitfields in fixed-endian structs
* annotated
* added conversions where needed
* fixed a couple of obvious brainos in (ifdefed out) zerocopy
stuff
Note that it's absofsckinglutely untested. It should not give differences
in behaviour on l-e, but
