On Tue, Dec 25, 2007 at 11:43:33PM +0100, Francois Romieu wrote:
> > +#define DESC_OWNER cpu_to_le16(0x8000)
> > +
>
> DESC_OWNER does not seem to be used.
*nod*
That should be removed.
> [...]
> > +enum {
> > + RX_INTEN = __constant_cpu_to_le16(0x8000)
> > +};
>
> Can we avoid using cpu_to_leXY here for consistency sake within the driver
> (and among different drivers as well) ?
???
What is the problem with having such constants? If you mean "could we
use cpu_to_le16() instead of __constant_cpu_to_le16()", the answer's
no - that's one of the very few places where __constant_.... form is
needed (other are case <...>: and initializers for non-auto variables).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
