Re: [PATCH] tcp-tso: fix faulty logic in tcp_tso_should_defer

2016-08-03 Thread Eric Dumazet
On Thu, 2016-08-04 at 12:01 +0800, Liang Ge wrote: > code does not match comment > > head = tcp_write_queue_head(sk); > skb_mstamp_get(&now); > age = skb_mstamp_us_delta(&now, &head->skb_mstamp); > /* If next ACK is likely to come too late (half srtt), do not defer */ >

[PATCH] tcp-tso: fix faulty logic in tcp_tso_should_defer

2016-08-03 Thread Liang Ge
code does not match comment head = tcp_write_queue_head(sk); skb_mstamp_get(&now); age = skb_mstamp_us_delta(&now, &head->skb_mstamp); /* If next ACK is likely to come too late (half srtt), do not defer */ if (age < (tp->srtt_us >> 4)) goto

Re: [PATCH] tcp-tso: fix faulty logic in tcp_tso_should_defer

2016-08-03 Thread Changli Gao
On Thu, Aug 4, 2016 at 12:01 PM, Liang Ge wrote: > > code does not match comment > > head = tcp_write_queue_head(sk); > skb_mstamp_get(&now); > age = skb_mstamp_us_delta(&now, &head->skb_mstamp); > /* If next ACK is likely to come too late (half srtt), do not defer