On Thu, Aug 4, 2016 at 12:01 PM, Liang Ge <lungoth...@gmail.com> wrote:
>
> code does not match comment
>
>         head = tcp_write_queue_head(sk);
>         skb_mstamp_get(&now);
>         age = skb_mstamp_us_delta(&now, &head->skb_mstamp);
>         /* If next ACK is likely to come too late (half srtt), do not defer */
>         if (age < (tp->srtt_us >> 4))
>                 goto send_now;
>
> This bug will cause TSO packets being transmitted too early, and force
> software to tear them apart.
>
> When ack clocking is likely to broke, this check will try to push out
> some EXTRA probe the first chance possible. Some transmission has
> already happened due to Eric's work.
>
> This patch fix the check.
> ---

Reviewed-by: Changli Gao <xiao...@gmail.com>



-- 
Regards,
Changli Gao(xiao...@gmail.com)

Reply via email to