Re: [PATCH] netxen: do_rom_fast_write error handling

2007-02-27 Thread Jeff Garzik
Stephen Hemminger wrote: Compiler warning spots real error! The function do_rom_fast_read called in do_rom_fast_write can fail and leave data1 unset. This causes a compile warning. The correct thing is to propagate the error out. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- dri

Re: [PATCH] netxen: do_rom_fast_write error handling

2007-02-26 Thread Amit Kale
Ah.. missed that. Thanks. -Amit On Tuesday 27 February 2007 04:21, Stephen Hemminger wrote: > Compiler warning spots real error! > > The function do_rom_fast_read called in do_rom_fast_write can fail > and leave data1 unset. This causes a compile warning. > The correct thing is to propagate the er

[PATCH] netxen: do_rom_fast_write error handling

2007-02-26 Thread Stephen Hemminger
Compiler warning spots real error! The function do_rom_fast_read called in do_rom_fast_write can fail and leave data1 unset. This causes a compile warning. The correct thing is to propagate the error out. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic_i