Compiler warning spots real error!
The function do_rom_fast_read called in do_rom_fast_write can fail
and leave data1 unset. This causes a compile warning.
The correct thing is to propagate the error out.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers/net/netxen/netxen_nic_init.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--- pktgen.orig/drivers/net/netxen/netxen_nic_init.c 2007-02-26
14:45:46.000000000 -0800
+++ pktgen/drivers/net/netxen/netxen_nic_init.c 2007-02-26 14:46:37.000000000
-0800
@@ -499,7 +499,10 @@
while(1) {
int data1;
- do_rom_fast_read(adapter, addridx, &data1);
+ ret = do_rom_fast_read(adapter, addridx, &data1);
+ if (ret < 0)
+ return ret;
+
if (data1 == data)
break;
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
