Re: [PATCH] net: stmmac: do not call phy_ethtool_ksettings_set from atomic context

2016-12-07 Thread David Miller
From: Niklas Cassel Date: Tue, 6 Dec 2016 14:47:15 +0100 > From: Niklas Cassel > > From what I can tell, spin_lock(&priv->lock) is not needed, since the > phy_ethtool_ksettings_set call is not given the priv struct. > > phy_start_aneg takes the phydev->lock. Calls to phy_adjust_link > from phy

[PATCH] net: stmmac: do not call phy_ethtool_ksettings_set from atomic context

2016-12-06 Thread Niklas Cassel
From: Niklas Cassel >From what I can tell, spin_lock(&priv->lock) is not needed, since the phy_ethtool_ksettings_set call is not given the priv struct. phy_start_aneg takes the phydev->lock. Calls to phy_adjust_link from phy_state_machine also takes the phydev->lock. [ 13.718319] BUG: sleepin