Re: [PATCH] net: socionext: replace napi_alloc_frag with the netdev variant on init

2019-04-22 Thread David Miller
From: Ard Biesheuvel Date: Fri, 19 Apr 2019 08:46:40 +0200 > On Thu, 18 Apr 2019 at 22:24, Ilias Apalodimas > wrote: >> >> Hi Ard, >> > > Use netdev_alloc_frag during the Rx ring setup instead napi_alloc_frag >> > > >> > >> > Why? >> > >> The netdev variant is usable on any context since it disa

Re: [PATCH] net: socionext: replace napi_alloc_frag with the netdev variant on init

2019-04-19 Thread Jassi Brar
On Fri, 19 Apr 2019 at 01:46, Ard Biesheuvel wrote: > > On Thu, 18 Apr 2019 at 22:24, Ilias Apalodimas > wrote: > > > > Hi Ard, > > > > Use netdev_alloc_frag during the Rx ring setup instead napi_alloc_frag > > > > > > > > > > Why? > > > > > The netdev variant is usable on any context since it di

Re: [PATCH] net: socionext: replace napi_alloc_frag with the netdev variant on init

2019-04-19 Thread Ard Biesheuvel
On Thu, 18 Apr 2019 at 22:24, Ilias Apalodimas wrote: > > Hi Ard, > > > Use netdev_alloc_frag during the Rx ring setup instead napi_alloc_frag > > > > > > > Why? > > > The netdev variant is usable on any context since it disables interrupts. > The napi variant of the call is supposed to be used un

Re: [PATCH] net: socionext: replace napi_alloc_frag with the netdev variant on init

2019-04-18 Thread Ilias Apalodimas
Hi Ard, > > Use netdev_alloc_frag during the Rx ring setup instead napi_alloc_frag > > > > Why? > The netdev variant is usable on any context since it disables interrupts. The napi variant of the call is supposed to be used under softirq context only > > Signed-off-by: Ilias Apalodimas > > -

Re: [PATCH] net: socionext: replace napi_alloc_frag with the netdev variant on init

2019-04-18 Thread Ard Biesheuvel
On Thu, 18 Apr 2019 at 11:27, Ilias Apalodimas wrote: > > Use netdev_alloc_frag during the Rx ring setup instead napi_alloc_frag > Why? > Fixes: 4acb20b46214 ("net: socionext: different approach on DMA") > Signed-off-by: Ilias Apalodimas > --- > drivers/net/ethernet/socionext/netsec.c | 11 +++

[PATCH] net: socionext: replace napi_alloc_frag with the netdev variant on init

2019-04-18 Thread Ilias Apalodimas
Use netdev_alloc_frag during the Rx ring setup instead napi_alloc_frag Fixes: 4acb20b46214 ("net: socionext: different approach on DMA") Signed-off-by: Ilias Apalodimas --- drivers/net/ethernet/socionext/netsec.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/dri