On Fri, 19 Apr 2019 at 01:46, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > > On Thu, 18 Apr 2019 at 22:24, Ilias Apalodimas > <ilias.apalodi...@linaro.org> wrote: > > > > Hi Ard, > > > > Use netdev_alloc_frag during the Rx ring setup instead napi_alloc_frag > > > > > > > > > > Why? > > > > > The netdev variant is usable on any context since it disables interrupts. > > The napi variant of the call is supposed to be used under softirq context > > only > > > > Helpful, thanks. In general, commit logs need to describe *why* you do > something, since *what* you do is usually obvious from the patch > itself, but why you do it isn't. > > With the above clarification added: > > Acked-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > Fine by me too.
Acked-by: Jassi Brar <jaswinder.si...@linaro.org> Thanks.