RE: [PATCH] net: phylib: fix interrupts re-enablement in phy_start

2016-05-10 Thread Shaohui Xie
> -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Wednesday, May 11, 2016 2:25 AM > To: shh@gmail.com; netdev@vger.kernel.org; da...@davemloft.net > Cc: Shaohui Xie ; Andrew Lunn > Subject: Re: [PATCH] net: phylib: fix interrupt

Re: [PATCH] net: phylib: fix interrupts re-enablement in phy_start

2016-05-10 Thread David Miller
From: Date: Tue, 10 May 2016 17:42:26 +0800 > From: Shaohui Xie > > If phy was suspended and is starting, current driver always enable > phy's interrupts, if phy works in polling, phy can raise unexpected > interrupt which will not be handled, the interrupt will block system > enter suspend aga

Re: [PATCH] net: phylib: fix interrupts re-enablement in phy_start

2016-05-10 Thread Florian Fainelli
On 05/10/2016 02:42 AM, shh@gmail.com wrote: > From: Shaohui Xie > > If phy was suspended and is starting, current driver always enable > phy's interrupts, if phy works in polling, phy can raise unexpected > interrupt which will not be handled, the interrupt will block system > enter suspend

[PATCH] net: phylib: fix interrupts re-enablement in phy_start

2016-05-10 Thread shh.xie
From: Shaohui Xie If phy was suspended and is starting, current driver always enable phy's interrupts, if phy works in polling, phy can raise unexpected interrupt which will not be handled, the interrupt will block system enter suspend again. So interrupts should only be re-enabled if phy works i