> -----Original Message----- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Wednesday, May 11, 2016 2:25 AM > To: shh....@gmail.com; netdev@vger.kernel.org; da...@davemloft.net > Cc: Shaohui Xie <shaohui....@nxp.com>; Andrew Lunn <and...@lunn.ch> > Subject: Re: [PATCH] net: phylib: fix interrupts re-enablement in phy_start > > On 05/10/2016 02:42 AM, shh....@gmail.com wrote: > > From: Shaohui Xie <shaohui....@nxp.com> > > > > If phy was suspended and is starting, current driver always enable > > phy's interrupts, if phy works in polling, phy can raise unexpected > > interrupt which will not be handled, the interrupt will block system > > enter suspend again. So interrupts should only be re-enabled if phy > > works in interrupt. > > Your explanation makes sense. The commit message could you use some > improvements like s/phy/PHY/ and "works in interrupt mode", but that is not a > huge thing. [S.H] Thank you for the comment.
I should make the commit message more precise and will make improvement in future patch submission. Regards, Shaohui
