On 2019/04/15 18:57, Jesper Dangaard Brouer wrote:
> On Mon, 15 Apr 2019 15:05:36 +0900
> Toshiaki Makita wrote:
>
>>> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
>>> index ef2cd5712098..6bc663249c4c 100644
>>> --- a/net/core/skbuff.c
>>> +++ b/net/core/skbuff.c
> [...]
>>> @@ -5095,6 +509
On Mon, 15 Apr 2019 15:05:36 +0900
Toshiaki Makita wrote:
> > diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> > index ef2cd5712098..6bc663249c4c 100644
> > --- a/net/core/skbuff.c
> > +++ b/net/core/skbuff.c
[...]
> > @@ -5095,6 +5096,13 @@ static struct sk_buff
> > *skb_reorder_vlan_header(
On 2019/04/15 17:06, Yuya Kusakabe wrote:
...
>>> @@ -5095,6 +5096,13 @@ static struct sk_buff
>>> *skb_reorder_vlan_header(struct sk_buff *skb)
...
>>> + meta = skb_metadata_end(skb) - meta_len;
>>> + memmove(meta + VLAN_HLEN, meta, meta_len);
>>> + };
I just not
On Mon, Apr 15, 2019 at 5:08 PM Toshiaki Makita
wrote:
>
> On 2019/04/15 16:43, Yuya Kusakabe wrote:
> ...
> > > @@ -5095,6 +5096,13 @@ static struct sk_buff
> > > *skb_reorder_vlan_header(struct sk_buff *skb)
> > > memmove(skb_mac_header(skb) + VLAN_HLEN,
> > skb_m
On 2019/04/15 16:43, Yuya Kusakabe wrote:
...
> > @@ -5095,6 +5096,13 @@ static struct sk_buff
> > *skb_reorder_vlan_header(struct sk_buff *skb)
> > memmove(skb_mac_header(skb) + VLAN_HLEN,
> skb_mac_header(skb),
> > mac_len - VLAN_HLEN -
Hi,
Thank you for the review.
On Mon, Apr 15, 2019 at 3:06 PM Toshiaki Makita
wrote:
>
> Hi,
> (CC: XDP maintainers)
>
> On 2019/04/13 21:16, Yuya Kusakabe wrote:
> > skb_reorder_vlan_header() should move XDP meta data with ethernet
> > header if XDP meta data exists.
> >
> > Signed-off-by: Yuya
Hi,
(CC: XDP maintainers)
On 2019/04/13 21:16, Yuya Kusakabe wrote:
> skb_reorder_vlan_header() should move XDP meta data with ethernet
> header if XDP meta data exists.
>
> Signed-off-by: Yuya Kusakabe
> Signed-off-by: Takeru Hayasaka
> Co-developed-by: Takeru Hayasaka
Missing fixes tag
Fix
skb_reorder_vlan_header() should move XDP meta data with ethernet
header if XDP meta data exists.
Signed-off-by: Yuya Kusakabe
Signed-off-by: Takeru Hayasaka
Co-developed-by: Takeru Hayasaka
---
net/core/skbuff.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/net
