On Mon, Apr 15, 2019 at 5:08 PM Toshiaki Makita
<makita.toshi...@lab.ntt.co.jp> wrote:
>
> On 2019/04/15 16:43, Yuya Kusakabe wrote:
> ...
> > > @@ -5095,6 +5096,13 @@ static struct sk_buff
> > > *skb_reorder_vlan_header(struct sk_buff *skb)
> > > memmove(skb_mac_header(skb) + VLAN_HLEN,
> > skb_mac_header(skb),
> > > mac_len - VLAN_HLEN - ETH_TLEN);
> > > }
> > > +
> > > + meta_len = skb_metadata_len(skb);
> > > + if (meta_len) {
> >
> > Since this is not used by non-XDP skb and skb path is slow-path for XDP
> > anyway, should add unlikely here in favor of non-XDP case?
> >
> >
> > I referred to meta data support of the ixgbe driver. It doesn't use
> > "unlikely".
> > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/tree/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c#n2176
>
> No need to conform to existing logic when we can improve it...
I understand.
> Anyway this is a minor point and I'm OK with either.
>
> Reviewed-by: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp>
>
> --
> Toshiaki Makita
>
Thank you!
--
Yuya Kusakabe
