Re: [PATCH] ipv4: fib_rules: Fix possible infinite loop in fib_empty_table

2018-12-28 Thread YueHaibing
On 2018/12/29 13:15, David Miller wrote: > From: YueHaibing > Date: Wed, 26 Dec 2018 16:34:20 +0800 > >> diff --git a/net/ipv4/fib_rules.c b/net/ipv4/fib_rules.c >> index f8eb78d..1567e12 100644 >> --- a/net/ipv4/fib_rules.c >> +++ b/net/ipv4/fib_rules.c >> @@ -200,9 +200,13 @@ static struct fi

Re: [PATCH] ipv4: fib_rules: Fix possible infinite loop in fib_empty_table

2018-12-28 Thread David Miller
From: YueHaibing Date: Wed, 26 Dec 2018 16:34:20 +0800 > diff --git a/net/ipv4/fib_rules.c b/net/ipv4/fib_rules.c > index f8eb78d..1567e12 100644 > --- a/net/ipv4/fib_rules.c > +++ b/net/ipv4/fib_rules.c > @@ -200,9 +200,13 @@ static struct fib_table *fib_empty_table(struct net *net) > { >

[PATCH] ipv4: fib_rules: Fix possible infinite loop in fib_empty_table

2018-12-26 Thread YueHaibing
gcc warn this: net/ipv4/fib_rules.c:203 fib_empty_table() warn: always true condition '(id <= 4294967295) => (0-u32max <= u32max)' 'id' is u32, which always not greater than RT_TABLE_MAX (0x), So add a check to break while wrap around. Signed-off-by: YueHaibing --- net/ipv4/fib_rules.c