gcc warn this: net/ipv4/fib_rules.c:203 fib_empty_table() warn: always true condition '(id <= 4294967295) => (0-u32max <= u32max)'
'id' is u32, which always not greater than RT_TABLE_MAX (0xFFFFFFFF), So add a check to break while wrap around. Signed-off-by: YueHaibing <[email protected]> --- net/ipv4/fib_rules.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/ipv4/fib_rules.c b/net/ipv4/fib_rules.c index f8eb78d..1567e12 100644 --- a/net/ipv4/fib_rules.c +++ b/net/ipv4/fib_rules.c @@ -200,9 +200,13 @@ static struct fib_table *fib_empty_table(struct net *net) { u32 id; - for (id = 1; id <= RT_TABLE_MAX; id++) + for (id = 1; id <= RT_TABLE_MAX; id++) { if (!fib_get_table(net, id)) return fib_new_table(net, id); + + if (id == RT_TABLE_MAX) + break; + } return NULL; } -- 2.7.4
