Re: [PATCH] dsa: rtl8366: Pass GENMASK() signed bits

2020-07-05 Thread Linus Walleij
On Sun, Jul 5, 2020 at 10:42 PM Andrew Lunn wrote: > Oddly, GENMASK() requires signed bit numbers, so that it can compare > them for < 0. If passed an unsigned type, we get warnings about the > test never being true. > > Signed-off-by: Andrew Lunn I just resent my RTL8366RB series and I picked

Re: [PATCH] dsa: rtl8366: Pass GENMASK() signed bits

2020-07-05 Thread David Miller
From: Florian Fainelli Date: Sun, 5 Jul 2020 13:49:10 -0700 > > > On 7/5/2020 1:42 PM, Andrew Lunn wrote: >> Oddly, GENMASK() requires signed bit numbers, so that it can compare >> them for < 0. If passed an unsigned type, we get warnings about the >> test never being true. >> >> Signed-off-by

Re: [PATCH] dsa: rtl8366: Pass GENMASK() signed bits

2020-07-05 Thread Florian Fainelli
On 7/5/2020 1:42 PM, Andrew Lunn wrote: > Oddly, GENMASK() requires signed bit numbers, so that it can compare > them for < 0. If passed an unsigned type, we get warnings about the > test never being true. > > Signed-off-by: Andrew Lunn The subject should also be prefixed with "net: " similar

[PATCH] dsa: rtl8366: Pass GENMASK() signed bits

2020-07-05 Thread Andrew Lunn
Oddly, GENMASK() requires signed bit numbers, so that it can compare them for < 0. If passed an unsigned type, we get warnings about the test never being true. Signed-off-by: Andrew Lunn --- drivers/net/dsa/rtl8366.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net